-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
observer leak bug fix #221
base: master
Are you sure you want to change the base?
Conversation
fix a observer leak if the developer set the show status to YES before add the handler.
I also create an issue about this bug. #222 |
Thanks! It really helped me. |
Can this be brought in? It otherwise crashes a lot of times for me when moving away from a controller that has pull to refresh and/or infinite scrolling enabled... |
@dennisreimann I don't understand. Could you provide more information or some sample code? |
@bestwnh All is fine, I just wanted to reassure that this is also happening for me in case your fix is not present. So please, merge this into the official version! |
@dennisreimann I really want to merge and already pull a request long time ago(Oct of 2014). But I don't receive any response. And I contact @samvermette and here is his response:
|
Well, that's sad. |
Yes. But he is still making some other amazing projects. So nothing to blame. |
Created a pull request in https://github.com/LawrenceHan/SVPullToRefresh |
@LawrenceHan Do whatever you want 😃 |
@bestwnh 昨天花了几个小时初步整理了一下pull request,fork到我的repo里了。 所以能先说明一下,你的这个pull request解决了什么问题? |
Oh, 同胞哦。问题说明在这上面有连接 #222 ,测试基本试过,其他人也用着没反馈新问题,其实就是加了个预判,不会引入什么新问题,你看看issue那边的说明然后看看相关代码就明白的了。 |
@bestwnh 已经合并了。 |
fix a observer leak if the developer set the show status to YES before
add the handler.