Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Pioneer journal paper to reference list #372

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

michaelcdevin
Copy link
Collaborator

Resolves #370

@michaelcdevin michaelcdevin added the documentation Improvements or additions to documentation label Oct 8, 2024
@michaelcdevin michaelcdevin requested a review from ryancoe October 8, 2024 23:22
@michaelcdevin michaelcdevin self-assigned this Oct 8, 2024
@coveralls
Copy link

coveralls commented Oct 8, 2024

Pull Request Test Coverage Report for Build 11295368056

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 94.514%

Files with Coverage Reduction New Missed Lines %
wecopttool/core.py 2 92.68%
Totals Coverage Status
Change from base Build 11281900098: -0.07%
Covered Lines: 2774
Relevant Lines: 2935

💛 - Coveralls

@michaelcdevin
Copy link
Collaborator Author

@ryancoe FYI checking this locally should now work with #374 being merged into dev.

Beyond that, this unintentionally opened up a can of worms a bit... There was a typo I missed in that PR, so I made #375 to resolve it, but that is now mysteriously failing for a completely unrelated error in Tutorial 4 which somehow never showed up in the CI until now. I will make a new issue for both the Tutorial 4 bug and the inconsistent CI testing if it makes sense to do so.

Ultimately though, the CI documentation build is broken anyway until #366 is fixed, so this specific PR can be merged whenever you check your local build and approve this PR.

@michaelcdevin michaelcdevin merged commit 2c3c9ab into sandialabs:dev Oct 11, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants