Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NumPy v2.0+ #391

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

michaelcdevin
Copy link
Collaborator

Description

With autograd being updated to work with NumPy v2.0 as of autograd v1.7.0 (yay!), we can now remove the version limitation for NumPy. This required updating a few references to variable aliases that NumPy v2 removes, but should still be compatible with earlier NumPy versions.

Type of PR

  • Bug fix
  • New feature
  • Documentation
  • Other: (specify)

Checklist for PR

@michaelcdevin michaelcdevin added upstream Related to a dependency of our package clean-up Tidy up code, fix non-breaking problems labels Jan 14, 2025
@michaelcdevin
Copy link
Collaborator Author

I'm keeping this as a draft for now due to some issues with wavespectra cooperating with newer versions of NumPy on Conda, see wavespectra/wavespectra#145. Because wavespectra doesn't have an explicit NumPy <2.0 designation (even though it is still downgrading for some reason), it doesn't downgrade other WecOptTool dependencies, which breaks the CI. So hold off on merging this until the upstream issue with wavespectra is resolved.

@michaelcdevin
Copy link
Collaborator Author

Error I'm seeing while running tests/test_integration.py if you're curious:

Windows fatal exception: code 0xWindows fatal exception: code 0xc06d007f

Thread 0x00000b90 (most recent call first):
  File "C:\Users\mcdevin\AppData\Local\miniforge3\envs\wot_py312_conda\Lib\site-packages\numpy\core\numeric.py

I believe numeric.py was one of the "problem modules" that caused autograd to break with NumPy v2.0 originally, so I think the NumPy downgrade due to wavespectra (without it downgrading other packages) is the culprit here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-up Tidy up code, fix non-breaking problems upstream Related to a dependency of our package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant