Ignore Spotbugs warning CT_CONSTRUCTOR_THROW (#2421)

scalar-labs · Dec 24, 2024 · a706e7f · a706e7f
1 parent 98b5e1b
commit a706e7f
Show file tree

Hide file tree

Showing 27 changed files with 2 additions and 105 deletions.
diff --git a/core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcAdminImportTestUtils.java b/core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcAdminImportTestUtils.java
@@ -118,10 +118,6 @@ public JdbcAdminImportTestUtils(Properties properties) {
     majorVersion = getMajorVersion();
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   public Map<String, TableMetadata> createExistingDatabaseWithAllDataTypes(String namespace)
       throws SQLException {
     execute(rdbEngine.createSchemaSqls(namespace));

diff --git a/...main/java/com/scalar/db/common/ActiveTransactionManagedDistributedTransactionManager.java b/...main/java/com/scalar/db/common/ActiveTransactionManagedDistributedTransactionManager.java
@@ -103,10 +103,6 @@ private ActiveTransaction(DistributedTransaction transaction) throws Transaction
       add(this);
     }
 
-    // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-    @Override
-    protected final void finalize() {}
-
     @Override
     public synchronized Optional<Result> get(Get get) throws CrudException {
       return super.get(get);

diff --git a/...n/java/com/scalar/db/common/ActiveTransactionManagedTwoPhaseCommitTransactionManager.java b/...n/java/com/scalar/db/common/ActiveTransactionManagedTwoPhaseCommitTransactionManager.java
@@ -110,10 +110,6 @@ private ActiveTransaction(TwoPhaseCommitTransaction transaction) throws Transact
       add(this);
     }
 
-    // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-    @Override
-    protected final void finalize() {}
-
     @Override
     public synchronized Optional<Result> get(Get get) throws CrudException {
       return super.get(get);

diff --git a/core/src/main/java/com/scalar/db/config/DatabaseConfig.java b/core/src/main/java/com/scalar/db/config/DatabaseConfig.java
@@ -84,10 +84,6 @@ public DatabaseConfig(Path propertiesPath) throws IOException {
     this(propertiesPath.toFile());
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   public Properties getProperties() {
     Properties ret = new Properties();
     ret.putAll(props);

diff --git a/core/src/main/java/com/scalar/db/io/BigIntColumn.java b/core/src/main/java/com/scalar/db/io/BigIntColumn.java
@@ -40,10 +40,6 @@ private BigIntColumn(String name, long value, boolean hasNullValue) {
     this.hasNullValue = hasNullValue;
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   @Override
   public String getName() {
     return name;

diff --git a/core/src/main/java/com/scalar/db/storage/cassandra/Cassandra.java b/core/src/main/java/com/scalar/db/storage/cassandra/Cassandra.java
@@ -88,10 +88,6 @@ public Cassandra(DatabaseConfig config) {
     this.operationChecker = operationChecker;
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   @Override
   @Nonnull
   public Optional<Result> get(Get get) throws ExecutionException {

diff --git a/core/src/main/java/com/scalar/db/storage/cassandra/CassandraConfig.java b/core/src/main/java/com/scalar/db/storage/cassandra/CassandraConfig.java
@@ -16,10 +16,6 @@ public CassandraConfig(DatabaseConfig databaseConfig) {
     metadataKeyspace = databaseConfig.getSystemNamespaceName();
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   public String getMetadataKeyspace() {
     return metadataKeyspace;
   }

diff --git a/core/src/main/java/com/scalar/db/storage/cosmos/Cosmos.java b/core/src/main/java/com/scalar/db/storage/cosmos/Cosmos.java
@@ -88,10 +88,6 @@ public Cosmos(DatabaseConfig databaseConfig) {
     this.operationChecker = operationChecker;
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   @Override
   @Nonnull
   public Optional<Result> get(Get get) throws ExecutionException {

diff --git a/core/src/main/java/com/scalar/db/storage/cosmos/CosmosConfig.java b/core/src/main/java/com/scalar/db/storage/cosmos/CosmosConfig.java
@@ -58,10 +58,6 @@ public CosmosConfig(DatabaseConfig databaseConfig) {
     consistencyLevel = getString(databaseConfig.getProperties(), CONSISTENCY_LEVEL, null);
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   public String getEndpoint() {
     return endpoint;
   }

diff --git a/core/src/main/java/com/scalar/db/storage/dynamo/Dynamo.java b/core/src/main/java/com/scalar/db/storage/dynamo/Dynamo.java
@@ -105,10 +105,6 @@ public Dynamo(DatabaseConfig databaseConfig) {
     this.operationChecker = operationChecker;
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   @Override
   @Nonnull
   public Optional<Result> get(Get get) throws ExecutionException {

diff --git a/core/src/main/java/com/scalar/db/storage/dynamo/DynamoConfig.java b/core/src/main/java/com/scalar/db/storage/dynamo/DynamoConfig.java
@@ -77,10 +77,6 @@ public DynamoConfig(DatabaseConfig databaseConfig) {
     namespacePrefix = getString(databaseConfig.getProperties(), NAMESPACE_PREFIX, null);
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   public String getRegion() {
     return region;
   }

diff --git a/core/src/main/java/com/scalar/db/storage/dynamo/Namespace.java b/core/src/main/java/com/scalar/db/storage/dynamo/Namespace.java
@@ -17,10 +17,6 @@ private Namespace(String prefix, String name) {
     this.name = name;
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   public static Namespace of(String prefix, String name) {
     return new Namespace(prefix, name);
   }

diff --git a/core/src/main/java/com/scalar/db/storage/jdbc/ConditionalMutator.java b/core/src/main/java/com/scalar/db/storage/jdbc/ConditionalMutator.java
@@ -56,10 +56,6 @@ public ConditionalMutator(
     this.queryBuilder = queryBuilder;
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   public boolean mutate() throws SQLException {
     mutation.getCondition().ifPresent(condition -> condition.accept(this));
     throwSQLExceptionIfOccurred();

diff --git a/core/src/main/java/com/scalar/db/storage/jdbc/JdbcConfig.java b/core/src/main/java/com/scalar/db/storage/jdbc/JdbcConfig.java
@@ -227,10 +227,6 @@ public JdbcConfig(DatabaseConfig databaseConfig) {
     }
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   public String getJdbcUrl() {
     return jdbcUrl;
   }

diff --git a/core/src/main/java/com/scalar/db/storage/jdbc/query/SelectWithFetchFirstNRowsOnly.java b/core/src/main/java/com/scalar/db/storage/jdbc/query/SelectWithFetchFirstNRowsOnly.java
@@ -13,10 +13,6 @@ public SelectWithFetchFirstNRowsOnly(Builder builder, int limit) {
     this.limit = limit;
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   @Override
   public String sql() {
     return super.sql() + " FETCH FIRST " + limit + " ROWS ONLY";

diff --git a/core/src/main/java/com/scalar/db/storage/jdbc/query/SelectWithLimitQuery.java b/core/src/main/java/com/scalar/db/storage/jdbc/query/SelectWithLimitQuery.java
@@ -13,10 +13,6 @@ public SelectWithLimitQuery(Builder builder, int limit) {
     this.limit = limit;
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   @Override
   public String sql() {
     return super.sql() + " LIMIT " + limit;

diff --git a/core/src/main/java/com/scalar/db/storage/jdbc/query/SelectWithTop.java b/core/src/main/java/com/scalar/db/storage/jdbc/query/SelectWithTop.java
@@ -13,10 +13,6 @@ public SelectWithTop(Builder builder, int limit) {
     this.limit = limit;
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   @Override
   public String sql() {
     // This inserts "TOP ${limit}" clause, specific to SqlServer, right after the "SELECT" clause of

diff --git a/core/src/main/java/com/scalar/db/storage/multistorage/MultiStorageConfig.java b/core/src/main/java/com/scalar/db/storage/multistorage/MultiStorageConfig.java
@@ -44,10 +44,6 @@ public MultiStorageConfig(DatabaseConfig databaseConfig) {
     checkIfStorageExists(defaultStorage);
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   private ImmutableMap<String, Properties> loadDatabasePropertiesMapping(Properties properties) {
     String[] storages = getStringArray(properties, STORAGES, null);
     if (storages == null) {

diff --git a/core/src/main/java/com/scalar/db/transaction/consensuscommit/ConsensusCommitConfig.java b/core/src/main/java/com/scalar/db/transaction/consensuscommit/ConsensusCommitConfig.java
@@ -189,10 +189,6 @@ public ConsensusCommitConfig(DatabaseConfig databaseConfig) {
             false);
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   public Isolation getIsolation() {
     return isolation;
   }

diff --git a/core/src/main/java/com/scalar/db/transaction/consensuscommit/Coordinator.java b/core/src/main/java/com/scalar/db/transaction/consensuscommit/Coordinator.java
@@ -332,10 +332,6 @@ public State(String id, TransactionState state) {
       this(id, state, System.currentTimeMillis());
     }
 
-    // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-    @Override
-    protected final void finalize() {}
-
     @VisibleForTesting
     State(String id, List<String> childIds, TransactionState state, long createdAt) {
       this.id = checkNotNull(id);

diff --git a/core/src/main/java/com/scalar/db/util/groupcommit/GroupCommitConfig.java b/core/src/main/java/com/scalar/db/util/groupcommit/GroupCommitConfig.java
@@ -64,10 +64,6 @@ public GroupCommitConfig(
         false);
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   public int slotCapacity() {
     return slotCapacity;
   }

diff --git a/gradle/spotbugs-exclude.xml b/gradle/spotbugs-exclude.xml
@@ -6,9 +6,10 @@
       <Bug pattern="THROWS_METHOD_THROWS_CLAUSE_THROWABLE"/>
       <Bug pattern="THROWS_METHOD_THROWS_RUNTIMEEXCEPTION"/>
       <!-- Temporarily excluded. See https://github.com/spotbugs/spotbugs/issues/1694 -->
-      <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE" />
+      <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
       <!-- To exclude Lombok thrown warnings -->
       <Bug pattern="SAME_NAME_BUT_DIFFERENT"/>
+      <Bug pattern="CT_CONSTRUCTOR_THROW"/>
     </Or>
   </Match>
 

diff --git a/schema-loader/src/main/java/com/scalar/db/schemaloader/ImportSchemaParser.java b/schema-loader/src/main/java/com/scalar/db/schemaloader/ImportSchemaParser.java
@@ -30,10 +30,6 @@ public ImportSchemaParser(String serializedSchemaJson, Map<String, String> optio
     this.options = ImmutableMap.copyOf(options);
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   public List<ImportTableSchema> parse() {
     List<ImportTableSchema> tableSchemaList = new ArrayList<>();
     for (Map.Entry<String, JsonElement> entry : schemaJson.entrySet()) {

diff --git a/schema-loader/src/main/java/com/scalar/db/schemaloader/ImportTableSchema.java b/schema-loader/src/main/java/com/scalar/db/schemaloader/ImportTableSchema.java
@@ -33,10 +33,6 @@ public ImportTableSchema(
     this.options = buildOptions(tableDefinition, options);
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   private ImmutableMap<String, String> buildOptions(
       JsonObject tableDefinition, Map<String, String> globalOptions) {
     ImmutableMap.Builder<String, String> optionsBuilder = ImmutableMap.builder();

diff --git a/schema-loader/src/main/java/com/scalar/db/schemaloader/SchemaOperator.java b/schema-loader/src/main/java/com/scalar/db/schemaloader/SchemaOperator.java
@@ -45,10 +45,6 @@ public SchemaOperator(Properties properties) {
     this(StorageFactory.create(properties), TransactionFactory.create(properties));
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   @VisibleForTesting
   SchemaOperator(StorageFactory storageFactory, TransactionFactory transactionFactory) {
     storageAdmin =

diff --git a/schema-loader/src/main/java/com/scalar/db/schemaloader/SchemaParser.java b/schema-loader/src/main/java/com/scalar/db/schemaloader/SchemaParser.java
@@ -31,10 +31,6 @@ public SchemaParser(String serializedSchemaJson, Map<String, String> options) {
     this.options = ImmutableMap.copyOf(options);
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   public List<TableSchema> parse() {
     List<TableSchema> tableSchemaList = new ArrayList<>();
     for (Map.Entry<String, JsonElement> entry : schemaJson.entrySet()) {

diff --git a/schema-loader/src/main/java/com/scalar/db/schemaloader/TableSchema.java b/schema-loader/src/main/java/com/scalar/db/schemaloader/TableSchema.java
@@ -70,10 +70,6 @@ public TableSchema(
     this.options = buildOptions(tableDefinition, options);
   }
 
-  // For the SpotBugs warning CT_CONSTRUCTOR_THROW
-  @Override
-  protected final void finalize() {}
-
   protected TableMetadata buildTableMetadata(String tableFullName, JsonObject tableDefinition) {
     TableMetadata.Builder tableBuilder = TableMetadata.newBuilder();