-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data chunk and task result enums and dtos #2442
base: master
Are you sure you want to change the base?
Conversation
@Builder | ||
@Value | ||
@JsonDeserialize(builder = ImportTaskResult.ImportTaskResultBuilder.class) | ||
public class ImportTaskResult { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly speaking, it's hard to me to get the relationship of these classes and how to use them from this PR. It would be great if there is a simple diagram or something to show the relationship.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my previous comment might be unclear. I just read the design document again. The definition of the following terms are still unclear to me, so adding comments about the definitions of xxxxx would be enough:
batch
(I guessImportTransactionBatch
is related)task
(I guessImportTaskAction
andImportTaskResult
are related)
Description
This PR adds enum and dtos used in data import for data chunks ssupport (smaller partitions of import data - data chunk details, status and state enums). And the dto for enums for import tasks and import result.
This also contains enums and dtos for transaction batch (to store transaction batch details, transaction batch status and result)
Related issues and/or PRs
NA
Changes made
I have added data chunk and task result enums and dtos for data loader import.
Checklist
Additional notes (optional)
Road map to merge remaining data loader core files. Current status
General
Export
Import
Release notes
NA