Merge pull request #14 from scality/improvement/improve-componentWith…

…InjectedImports-type improve componentWithInjectedImports type
scality · Nov 18, 2024 · 97e0434 · 97e0434
2 parents 7ade439 + abe6bb5
commit 97e0434
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@scality/module-federation",
-  "version": "1.3.3",
+  "version": "1.3.4",
   "description": "",
   "main": "build/ModuleFederation.js",
   "scripts": {

diff --git a/src/ModuleFederation.tsx b/src/ModuleFederation.tsx
@@ -136,9 +136,11 @@ export const ComponentWithFederatedImports = <Props extends {}>({
   componentProps,
   federatedImports,
 }: {
-  renderOnError: ReactNode;
+  renderOnError?: ReactNode;
   renderOnLoading?: ReactNode;
-  componentWithInjectedImports: FunctionComponent<Props>;
+  componentWithInjectedImports: FunctionComponent<
+    Props & { moduleExports: Record<string, unknown> }
+  >;
   componentProps: Props;
   federatedImports: {
     remoteEntryUrl: string;