keep endpoint urls out of lower level code

schlawg · Sep 24, 2024 · 24adaa7 · 24adaa7
1 parent a175574
commit 24adaa7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/main/scala/Controller.scala b/src/main/scala/Controller.scala
@@ -155,7 +155,8 @@ final class Controller(
                 ) { Deps(emit, req, services) },
               header,
               credits = 100,
-              interval = 20.seconds
+              interval = 20.seconds,
+              alwaysFlush = true
             )
           case _ => notFound
 
@@ -302,14 +303,15 @@ object Controller:
       val rateLimit: RateLimit,
       val header: RequestHeader,
       val emitCounter: kamon.metric.Counter,
-      val name: String
+      val alwaysFlush: Boolean
   )
   def endpoint(
       name: String,
       behavior: ClientEmit => ClientBehavior,
       header: RequestHeader,
       credits: Int,
-      interval: FiniteDuration
+      interval: FiniteDuration,
+      alwaysFlush: Boolean = false
   ): ResponseSync =
     Monitor.connection.open(name)
     Right:
@@ -322,7 +324,7 @@ object Controller:
         ),
         header,
         Monitor.clientInCounter(name),
-        name
+        alwaysFlush
       )
 
   type ResponseSync = Either[HttpResponseStatus, Endpoint]

diff --git a/src/main/scala/netty/ActorChannelConnector.scala b/src/main/scala/netty/ActorChannelConnector.scala
@@ -18,7 +18,7 @@ final private class ActorChannelConnector(clients: ActorRef[Clients.Control], lo
     val clientPromise = Promise[Client]()
     channel.attr(key.client).set(clientPromise.future)
     val channelEmit: ClientEmit =
-      emitToChannel(channel, withFlush = endpoint.name == "round/play")
+      emitToChannel(channel, withFlush = endpoint.alwaysFlush)
     val monitoredEmit: ClientEmit = (msg: ipc.ClientIn) =>
       endpoint.emitCounter.increment()
       channelEmit(msg)