Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DistSet SelectorGetDistSet function for H-bo… #373

Closed
wants to merge 1 commit into from

Conversation

norbert1000
Copy link
Contributor

When using the dist command with mode=2 for structures that have sensibly placed polar hydrogens, it becomes apparent that many hydrogen bonds with very good geometry are missed. The problem only affects atom pairs in which both atoms can have a donor and an acceptor function (i.e. waters, Ser, Thr, His and ligands).

Origin of this behavior is the DistSet SelectorGetDistSet function in layer3/Selector.cpp:

if(ai1->hb_donor && ai2->hb_acceptor) {
//check for suitable geometry
} else if(ai1->hb_acceptor && ai2->hb_donor) {
//check for suitable geometry
} else {
//no hydrogen bond
}

If both atoms are donor and acceptor, both possibilities need to be tested.
@folmilsch will post a modification that takes care of this situation.

…nds with hydrogens

To be described in pull request
@norbert1000
Copy link
Contributor Author

Please delete this pull request, it is duplicated in #374. Sorry.

@JarrettSJohnson
Copy link
Member

Closed as requested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants