Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to universal_web #363

Merged
merged 5 commits into from
Jan 12, 2025
Merged

migrate to universal_web #363

merged 5 commits into from
Jan 12, 2025

Conversation

schultek
Copy link
Owner

@schultek schultek commented Jan 7, 2025

Description

  • refactor GlobalKey
  • add GlobalStateKey and GlobalNodeKey

Type of Change

  • ❌ Breaking change
  • ✨ New feature or improvement

Copy link

docs-page bot commented Jan 7, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/schultek/jaspr~363

Documentation is deployed and generated using docs.page.

Copy link

github-actions bot commented Jan 7, 2025

Package Version Report

The following packages have been updated:
jaspr : 0.16.4 -> 0.17.0
jaspr_builder : 0.16.4 -> 0.17.0
jaspr_cli : 0.16.4 -> 0.17.0
jaspr_flutter_embed : 0.4.2 -> 0.4.3
jaspr_riverpod : 0.3.16 -> 0.3.17
jaspr_router : 0.6.0 -> 0.6.1
jaspr_serverpod : 0.5.0 -> 0.5.1
jaspr_test : 0.16.4 -> 0.17.0

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 18.75000% with 52 lines in your changes missing coverage. Please review.

Project coverage is 74.98%. Comparing base (7ccc0a1) to head (0693efd).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
packages/jaspr/lib/src/framework/keys.dart 18.96% 47 Missing ⚠️
packages/jaspr/lib/src/foundation/object.dart 0.00% 4 Missing ⚠️
...ges/jaspr/lib/src/server/markup_render_object.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   75.86%   74.98%   -0.89%     
==========================================
  Files         129      128       -1     
  Lines        5486     5564      +78     
==========================================
+ Hits         4162     4172      +10     
- Misses       1324     1392      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schultek schultek marked this pull request as ready for review January 12, 2025 10:45
@schultek schultek merged commit 382fa4c into main Jan 12, 2025
3 of 5 checks passed
@schultek schultek deleted the feat/universal-web branch January 12, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant