Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging error when no reverse image are provided #13

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

gagnonanthony
Copy link
Collaborator

When trying to run the pipeline with --skip_dwi_preprocessing without submitting a reverse b0 image, the subworkflow loading the data returned an error. Changed the assertion to omit if --skip_dwi_preprocessing is selected. Tests should catch it now.

It will be removed when we switch to mandatory BIDS input.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@gagnonanthony gagnonanthony added the bug Something isn't working label Jan 17, 2025
@gagnonanthony gagnonanthony self-assigned this Jan 17, 2025
@gagnonanthony gagnonanthony changed the title Fix logging error whe no reverse image are provided Fix logging error when no reverse image are provided Jan 17, 2025
@gagnonanthony gagnonanthony merged commit 5c31c02 into scilus:main Jan 17, 2025
13 checks passed
@gagnonanthony gagnonanthony deleted the fix/logmissinginputfiles branch January 17, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant