Override names in legend for inputs that are part of a dict #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, when we were passing data array in a dict, but they already had names, the keys in the dict would not be used in the legend.
This meant that for example
would show
DA1
andDA2
in the legend, which is confusing since you would think if you pass a dict, those keys would be used. The.name
on a data array may have been sat in a very different place, if fx it was inserted in aDataset
many lines above in the notebook.Now, the keys of the dict (or DataGroup) override the underlying names on the input.
Note that the inputs' names are not modified in-place.