Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(realcommand): Don't use pytest.skipif #1285

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

yedayak
Copy link
Collaborator

@yedayak yedayak commented Dec 1, 2024

This function doesn't actually exist. Also added an error message, this really should never happen.

@akinomyoga
Copy link
Collaborator

Also, the variable name skipif seems the opposite. If the command ! type -P non-existent-... succeeds, the test is performed. When skipif is not satisfied, the test is skipped.

This function doesn't actually exist. Also added an error message, this
really should never happen.

Co-Authored-By: Koichi Murase <[email protected]>
@yedayak yedayak force-pushed the realcommand-skipif branch from 511e904 to f80267c Compare December 2, 2024 19:28
@akinomyoga akinomyoga merged commit 559cf7b into scop:main Dec 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants