Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aptitude): add showsrc and source options #1313

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(aptitude): add showsrc and source options #1313

wants to merge 1 commit into from

Conversation

inconstante
Copy link
Contributor

This fix has been provided to Debian (downstream) by Heinrich Schuchardt [email protected]. It is currently a downstream patch, but it should be here.

@akinomyoga
Copy link
Collaborator

When was the original patch created? There seem to be even more subcommands in some manual:

  • https://www.debian.org/doc/manuals/aptitude/rn01re01.en.html

    add-user-tag autoclean build-dep build-depends changelog clean download extract-cache-subset forbid-version forget-new full-upgrade help hold install keep-all markauto purge reinstall remove remove-user-tag safe-upgrade search show showsrc source unhold unmarkauto update versions why why-not

Also, upgrade and dist-upgrade seem to have been renamed to full-upgrade, and the old names were deprecated.

@inconstante
Copy link
Contributor Author

When was the original patch created?

More than 2 years ago (https://salsa.debian.org/debian/bash-completion/-/merge_requests/5/diffs?commit_id=e68fde20600326e426e802233e46c940cab9478b)

There seem to be even more subcommands in some manual:

* https://www.debian.org/doc/manuals/aptitude/rn01re01.en.html
  add-user-tag autoclean build-dep **build-depends** changelog clean **download** **extract-cache-subset** forbid-version forget-new full-upgrade **help** hold install keep-all markauto purge reinstall remove remove-user-tag safe-upgrade search show showsrc source unhold unmarkauto update versions why why-not

Also, upgrade and dist-upgrade seem to have been renamed to full-upgrade, and the old names were deprecated.

You're right. Let me review this and write a more comprehensive patch.

Thanks for your review.

@inconstante
Copy link
Contributor Author

I pushed a revised version with the sub-commands listed by the manpage.

I used the following one-liner:

man aptitude | grep -E "^ {7}[a-z]" | tail -n 26 | head -n 24 | tr ',' '\n' | tr -d ' ' | sort | tr '\n' ' '

which found another sub-command: keep

The list is now sorted alphabetically.

PS: I think download has always been there.

scop
scop reviewed Jan 14, 2025
View reviewed changes
completions/aptitude Outdated Show resolved Hide resolved
@inconstante
feat(aptitude): update sub-commands
1b09c48 
The following commands are listed in the manpage and were missing from
the completion file:

    build-depends
    extract-cache-subset
    help

Whereas the following commands are not listed in the manpage nor in the
documentation:

    dist-upgrade
    upgrade

Moreover, build-depends and build-deps are aliases, and bash-completion
guidelines (CONTRIBUTING.md) recommend using the longer version.

This patch updates the list and sorts it by-name.

Suggested-by: Heinrich Schuchardt <[email protected]>
Suggested-by: Koichi Murase <[email protected]>
@inconstante
Copy link
Contributor Author

Pull request updated. Thanks for your reviews! :)

@inconstante inconstante requested a review from scop January 19, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akinomyoga akinomyoga akinomyoga approved these changes

@scop scop Awaiting requested review from scop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inconstante @akinomyoga @scop