Brctl #866
Merged
Brctl #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steelman
force-pushed
the
brctl
branch
3 times, most recently
from
daed251 to
7e42273
Compare
|
Why? With |
scop
reviewed
Jan 12, 2023
scop
reviewed
Jan 12, 2023
akinomyoga
reviewed
May 14, 2024
Do not turn the option to use file names as possible completion for brctl as the command does not deal with files whatsoever.
When adding a network interface to a bridge we most probably want to use one that hasn't been configured yet.
steelman
force-pushed
the
brctl
branch
2 times, most recently
from
9d87e5b to
7b83351
Compare
akinomyoga
reviewed
Nov 29, 2024
akinomyoga
reviewed
Nov 29, 2024
It's not a big deal, but I think there is a typo in the commit message. |
steelman
force-pushed
the
brctl
branch
3 times, most recently
from
5cb1665 to
7e8441f
Compare
When completing a delif command offer only interfaces that are part of the selected bridge.
The show subcommand accepts a bridge name as a paramenter so let's offer completion. On the other hand addbr creates new interface and requires a name that doesn't exist yet. Longer awk condition prevents offering interfaces that are parts of bridges. They are all displayed in the last column but with all other columns being blang on the second and following lines of each bridge the last column is also the first.
scop
approved these changes
Dec 29, 2024
|
Sorry, I had a "pending" review that I forgot to submit. I added it in #1296. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternatively
addbrcould also get completion of available bridges to enable avoiding clashes.