Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in score-helm callout #107

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Fix links in score-helm callout #107

merged 1 commit into from
Jun 21, 2024

Conversation

TobiasBabin
Copy link
Contributor

@TobiasBabin TobiasBabin commented Jun 21, 2024

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

The links on the newly added callout on score-helm deprecation are broken on the rendered site.

image

Clicking one of the marked links results in:
image

What does this change do?

The change replaces markdown links with the Hugo style relref format.

What is your testing strategy?

I started the Hugo test server locally and checked the result in the rendered site.

Is this related to any issues?

No.

Have you read the Contributing Guidelines?

@TobiasBabin TobiasBabin requested a review from sujaya-sys June 21, 2024 12:48
Copy link
Contributor

@sujaya-sys sujaya-sys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! Wrong formatting, thanks for catching this

@TobiasBabin TobiasBabin merged commit eab7db5 into main Jun 21, 2024
3 checks passed
@TobiasBabin TobiasBabin deleted the fix-deprecation-links branch June 21, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants