-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop six requirement #438
drop six requirement #438
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #438 +/- ##
==========================================
- Coverage 89.45% 89.44% -0.02%
==========================================
Files 34 34
Lines 2438 2407 -31
==========================================
- Hits 2181 2153 -28
+ Misses 257 254 -3 ☔ View full report in Codecov by Sentry. |
94a5e05
to
9b2aa72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
btw, any interest in raising the minimum python to 3.8 (since older versions are EOL)? |
Yeah, I don't think it's useful to keep support for pre-3.8. |
46c7ce9
to
e44b6ee
Compare
Rebased to resolve conflicts after #434 |
I noticed
six
is still required/used even though only 3.6+ is supportedpipx run pyupgrade --py36-plus $(git ls-files '*.py')
six
and updating requirements