Code

New ItemPage#74

Code

Merged

kmike merged 26 commits intomasterscrapinghub/web-poet:masterfrom new-item-pagescrapinghub/web-poet:new-item-pageCopy head branch name to clipboardAug 25, 2022

+638-338

Commits

Commits on Aug 17, 2022

• Fixed fields in subclasses. Fixes GH-69.

  kmike

  committed
  031fcec

  Copy full SHA for 031fcec

Commits on Aug 18, 2022

• Merge branch 'master' into new-item-page

  kmike

  committed
  aa8dec7

  Copy full SHA for aa8dec7

• more type annotations

  kmike

  committed
  9508871

  Copy full SHA for 9508871

• items support using a generic ItemPage class

  kmike

  committed
  352d8bb

  Copy full SHA for 352d8bb

• fix tests to account for new behavior

  kmike

  committed
  7a772d7

  Copy full SHA for 7a772d7

• tests for types

  kmike

  committed
  4d33526

  Copy full SHA for 4d33526

• run types tests on github actions

  kmike

  committed
  187733c

  Copy full SHA for 187733c

• fixed typing issues

  kmike

  committed
  a509f44

  Copy full SHA for a509f44

• backwards compat for Python 3.7

  kmike

  committed
  fa947d8

  Copy full SHA for fa947d8

Commits on Aug 19, 2022

• more tests; skip_nonitem_fields argument

  kmike

  committed
  d14ebd0

  Copy full SHA for d14ebd0

• fix typing issue

  kmike

  committed
  db2d875

  Copy full SHA for db2d875

• extract SetItemType

  kmike

  committed
  4b0d66e

  Copy full SHA for 4b0d66e

• update fields tutorial

  kmike

  committed
  706a22b

  Copy full SHA for 706a22b

• rename SetItemType to Returns

  kmike

  committed
  45107c4

  Copy full SHA for 45107c4

• typo fix

  kmike

  committed
  dd03bc6

  Copy full SHA for dd03bc6

• item_cls_fields -> skip_nonitem_fields

  kmike

  committed
  161c46a

  Copy full SHA for 161c46a

• added a comment to tox.ini temporary dependency

  kmike

  committed
  58bd8e5

  Copy full SHA for 58bd8e5

• deprecate ItemWebPage

  kmike

  committed
  05a9163

  Copy full SHA for 05a9163

• test WebPage + fields

  kmike

  committed
  e452588

  Copy full SHA for e452588

Commits on Aug 20, 2022

• clean up from-fround-up tutorial

  kmike

  committed
  e74f123

  Copy full SHA for e74f123

Commits on Aug 23, 2022

• Merge branch 'master' into new-item-page

  Show description for b85bc1c
  kmike

  committed
  b85bc1c

  Copy full SHA for b85bc1c

• typo fix

  kmike

  committed
  99d3479

  Copy full SHA for 99d3479

Commits on Aug 24, 2022

• Apply suggestions from code review

  Show description for 5b01db1
  

  3 peopleauthored
  5b01db1

  Copy full SHA for 5b01db1

• ignore B024 flake8-bugbear warning

  kmike

  committed
  0bdb50a

  Copy full SHA for 0bdb50a

• more tests for ItemPage validation

  kmike

  committed
  98c2627

  Copy full SHA for 98c2627

• mention to_item earlier in docs

  kmike

  committed
  28f917a

  Copy full SHA for 28f917a