test: update test to check r.Failed instead of error for "failed when…

… contains" issues
scrapli · Dec 3, 2022 · bff9f38 · bff9f38
1 parent 1ff1aa4
commit bff9f38
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/driver/generic/sendcommand.go b/driver/generic/sendcommand.go
@@ -30,10 +30,6 @@ func (d *Driver) sendCommand(
 
 	r.Record(b)
 
-	if r.Failed != nil {
-		return nil, r.Failed
-	}
-
 	return r, nil
 }
 

diff --git a/driver/generic/sendcommand_test.go b/driver/generic/sendcommand_test.go
@@ -90,12 +90,16 @@ func testSendCommandFails(testName string, testCase *sendCommandTestCase) func(t
 
 		d, _ := prepareDriver(t, testName, testCase.payloadFile)
 
-		_, err := d.SendCommand(testCase.command)
-		if err == nil {
-			t.Errorf(
-				"%s: expected error running network Driver SendCommand, got: %s",
+		r, err := d.SendCommand(testCase.command)
+		if err != nil {
+			t.Fatalf("%s: response object indicates failure",
+				testName)
+		}
+
+		if r.Failed == nil {
+			t.Fatalf(
+				"%s: expected r.Failed to be set",
 				testName,
-				err,
 			)
 		}
 	}