Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix The annoyning Deprecation issue in _middlewares.py #234

Merged
merged 2 commits into from
Dec 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scrapy_zyte_api/_middlewares.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ def slot_request(self, request, spider, force=False):
return

downloader = self._crawler.engine.downloader
slot_id = downloader._get_slot_key(request, spider)
try:
slot_id = downloader.get_slot_key(request)
except AttributeError: # Scrapy < 2.12
slot_id = downloader._get_slot_key(request, spider)
if not isinstance(slot_id, str) or not slot_id.startswith(self._slot_prefix):
slot_id = f"{self._slot_prefix}{slot_id}"
request.meta["download_slot"] = slot_id
Expand Down
Loading