Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move scratch-analysis to GitHub Actions #65

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

delasare
Copy link
Contributor

@delasare delasare commented Dec 8, 2023

Resolves

What Github issue does this resolve (please include link)? Please do not submit PRs that are not associated with an issue, or that only partially implement a fix.

Proposed Changes

  • add github directory and associated files
  • add nvmrc file and update node version
  • convert workflow to github actions
  • remove circle config

Ron de las Alas added 3 commits December 8, 2023 14:24
chore: include the package-lock

chore: add nvmrc file

chore: add semeantic release config
Copy link
Contributor

@cwillisf cwillisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing the npm install vs npm ci confusion!
The one significant change I see is the removal of the Slack notifications. I think that's OK, but I'd like others to have a chance to object. If there's no objection then :shipit:

@@ -4,7 +4,6 @@
## NPM
/node_modules
npm-*
package-lock.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@delasare delasare changed the title Rd/eng 50/transition scratch analysis Move scratch-analysis to GitHub Actions Dec 14, 2023
@delasare delasare merged commit 0f4220d into develop Dec 14, 2023
1 of 2 checks passed
@delasare delasare deleted the rd/ENG-50/transition-scratch-analysis branch December 14, 2023 13:19
@cwillisf cwillisf mentioned this pull request Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants