BLE: allow client to override write with/without response #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwillisf
requested review from
fsih
and removed request for
paulkaplan and
kchadha
cwillisf
changed the title
|
LGTM. |
fsih
approved these changes
Nov 19, 2019
| @@ -338,7 +338,7 @@ private async Task<JToken> Write(JObject parameters) | |||
| { | |||
| var buffer = EncodingHelpers.DecodeBuffer(parameters); | |||
| var endpoint = await GetEndpoint("write request", parameters, GattHelpers.BlockListStatus.ExcludeWrites); | |||
| var withResponse = (parameters["withResponse"]?.ToObject<bool>() ?? false) || | |||
| var withResponse = parameters["withResponse"]?.ToObject<bool>() ?? | |||
| !endpoint.CharacteristicProperties.HasFlag(GattCharacteristicProperties.WriteWithoutResponse); | |||
There was a problem hiding this comment.
Set to a variable "the characteristic thinks we MUST write WITH response"
There was a problem hiding this comment.
It might be good to say that we explicitly expect an error if the gatt characteristic does not have property write with response (because then we're trying to write and we're not allowed to write at all)
| @@ -297,7 +297,10 @@ class BLESession: Session, SwiftCBCentralManagerDelegate, SwiftCBPeripheralDeleg | |||
| return | |||
| } | |||
|
|
|||
| let writeType = (withResponse || !endpoint.properties.contains(.writeWithoutResponse)) ? | |||
| // If the client specified a write type, honor that. | |||
There was a problem hiding this comment.
Add this comment to c# as well
| // If the client specified a write type, honor that. | ||
| // Otherwise, if the characteristic claims to support writing without response, do that. | ||
| // Otherwise, write with response. | ||
| let writeType = (withResponse ?? !endpoint.properties.contains(.writeWithoutResponse)) ? |
There was a problem hiding this comment.
withResponse = withResponse ?? !endpoint.properties.contains(.writeWithoutResponse));
let writeType = withResponse ? x : y
might be more clear?
|
I'm going to merge this as-is for now but I've filed #161 to follow up on the review comments later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #150
Closes #154
Proposed Changes
In #154, @terado0618 implemented a fix for #150 on Windows. This PR includes #154 along with a similar change for macOS and documentation of the new behavior.
Reason for Changes
This offers a significant performance boost on Windows: see this comment. Performance on macOS seems to be acceptable without this change, but I think it's important for the hardware communication to be similar on both platforms so that extensions don't need to worry about platform differences.
This PR should be merged with scratchfoundation/scratch-vm#2298.
@terado0618, please let me know if you have concerns about this PR. Thanks!