-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support local prover && multiple task types #54
base: main
Are you sure you want to change the base?
Conversation
yiweichi
commented
Jan 5, 2025
•
edited
Loading
edited
- Support local prover
- Support multiple task types in one prover process
} | ||
|
||
#[derive(Debug, Serialize, Deserialize, Clone)] | ||
pub struct DbConfig {} | ||
|
||
impl Config { | ||
pub fn from_reader<R>(reader: R) -> anyhow::Result<Self> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better keep anyhow::Result
, rust Instructs us to write it this way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean change anyhow::Result<Self>
to Result<Self>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, still keep anyhow::Result
Actually, I think we should combine this repo and prover repo to small one, let this repo become a crate of prover. wdyt @Thegaram the layout maybe like this
|
for the easily usage, we should simpfy some config option like |
Co-authored-by: georgehao <[email protected]>
…l-tech/scroll-proving-sdk into feat-integrate-proving-sdk