Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support local prover && multiple task types #54

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

yiweichi
Copy link
Member

@yiweichi yiweichi commented Jan 5, 2025

  1. Support local prover
  2. Support multiple task types in one prover process

@yiweichi yiweichi changed the title feat: local prover && support multiple task types feat: support local prover && support multiple task types Jan 5, 2025
@yiweichi yiweichi changed the title feat: support local prover && support multiple task types feat: support local prover && multiple task types Jan 5, 2025
@yiweichi yiweichi requested review from georgehao and Thegaram January 6, 2025 07:07
src/config.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
}

#[derive(Debug, Serialize, Deserialize, Clone)]
pub struct DbConfig {}

impl Config {
pub fn from_reader<R>(reader: R) -> anyhow::Result<Self>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better keep anyhow::Result, rust Instructs us to write it this way

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean change anyhow::Result<Self> to Result<Self>?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, still keep anyhow::Result

src/config.rs Outdated Show resolved Hide resolved
src/prover/builder.rs Outdated Show resolved Hide resolved
src/prover/types.rs Outdated Show resolved Hide resolved
@georgehao
Copy link
Member

Actually, I think we should combine this repo and prover repo to small one, let this repo become a crate of prover. wdyt @Thegaram

the layout maybe like this

prover
---- cargo.toml
        cargo.lock
        crates
           ----  wrapper ( contains coordinator client, geth client, circuit, etc)
           ----  local
           ----  remote  

@georgehao
Copy link
Member

for the easily usage, we should simpfy some config option like n_workers http option, we should have a default value for it, ane make it to a optional field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants