Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick the batching implementation from #8 to the wrapper code #11

Open
wants to merge 24 commits into
base: feat/ceno-binding
Choose a base branch
from

Conversation

yczhangsjtu
Copy link
Collaborator

Pick the batching implementation from #8 to the wrapper code

@yczhangsjtu
Copy link
Collaborator Author

Benchmark results for num vars = 20:

For single polynomial:

  • Commit: 118.89 ms
  • Open: 237.44 ms
  • Verify: 1.0043 ms

For 64 polynomials:

  • Commit: 5.4084 s
  • Open: 2.3355 s
  • Verify: 1.3665 ms

@yczhangsjtu
Copy link
Collaborator Author

yczhangsjtu commented Jan 16, 2025

For comparison with BaseFold:

1 poly:

  • Commit: 162.23 ms
  • Open: 192.95 ms
  • Verify: 3.6355 ms

64 polys:

  • Commit: 1.5916 s
  • Open: 226.44 ms
  • Verify: 3.8251 ms

@yczhangsjtu
Copy link
Collaborator Author

With some fixes: make some loops parallel, remove an unnecessary clone.

For 64 polys with 20 variables:

  • Commit: 3.2243 s
  • Open: 252.23 ms
  • Verify: 3.0184 ms

@yczhangsjtu
Copy link
Collaborator Author

  • For 64 polys with 20 variables:
    • Commit: 3.0252 s (originally 5.4084 s)
    • Open: 200.19 ms (originally 2.3355 s)
    • Verify: 1.6396 ms (originally 1.3665 ms)

@yczhangsjtu
Copy link
Collaborator Author

yczhangsjtu commented Jan 23, 2025

Proof size:

WHIR for num var = 20

  • Single poly: 87704 Bytes (BaseFold 1303205 Bytes)
  • 64 polys: 1412408 Bytes (BaseFold 1506405 Bytes) This is problematic, shouldn't increase that much. Maybe because of unnecessary Merkle paths for the extra polynomials?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant