Merge pull request #163 from scrtlabs/fix-signAmino-memo

`signAmino()`: use `memo` from signed transaction instead of from the caller
scrtlabs · Mar 18, 2024 · 2defd1b · 2defd1b
2 parents f66b467 + 505ef9a
commit 2defd1b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog & Version Info
 
+## 1.12.5
+
+Fix `signAmino()` to broadcast the memo from the signer (wallet) instead of the memo from the caller.
+
 ## 1.12.4
 
 Fix `txsQuery()` for Cosmos SDK v0.46+ chains

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "secretjs",
   "description": "The JavaScript SDK for Secret Network",
-  "version": "1.12.4",
+  "version": "1.12.5",
   "license": "MIT",
   "author": "SCRT Labs",
   "bugs": {

diff --git a/src/secret_network_client.ts b/src/secret_network_client.ts
@@ -1904,7 +1904,7 @@ export class SecretNetworkClient {
             return asProto;
           }),
         ),
-        memo: memo,
+        memo: signed.memo, // memo might have been changed by the wallet before signing
       },
     };
     const txBodyBytes = await this.encodeTx(txBody);