-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert uglification of CLI options #1668
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1668 +/- ##
==========================================
- Coverage 86.87% 84.40% -2.47%
==========================================
Files 39 39
Lines 6033 6033
==========================================
- Hits 5241 5092 -149
- Misses 792 941 +149 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies! was very frustrated and trying many different things but the dry run was working so there was no need to try this!
|
Maybe I'm missing something: >>> from packaging import version
>>> version.Version("1.0")
<Version('1.0')>
>>> version.Version("1.0").release
(1, 0) |
@ilan-gold in #1654, this was made uglier.
My local version of
gh
has no problem with the cleaner version of CLI option specification, so why not like this?