Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert uglification of CLI options #1668

Merged
merged 8 commits into from
Sep 16, 2024
Merged

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Sep 5, 2024

@ilan-gold in #1654, this was made uglier.

My local version of gh has no problem with the cleaner version of CLI option specification, so why not like this?

@flying-sheep flying-sheep modified the milestones: 0.10.10, 0.11.0 Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.40%. Comparing base (a3924c1) to head (901dbde).
Report is 56 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1668      +/-   ##
==========================================
- Coverage   86.87%   84.40%   -2.47%     
==========================================
  Files          39       39              
  Lines        6033     6033              
==========================================
- Hits         5241     5092     -149     
- Misses        792      941     +149     

see 8 files with indirect coverage changes

Copy link
Contributor

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies! was very frustrated and trying many different things but the dry run was working so there was no need to try this!

@flying-sheep
Copy link
Member Author

flying-sheep commented Sep 16, 2024

OK. Please also check out e844f18, the validation was broken too!

(len(Version(...).release) == 3 is always True, we must match the raw string)

@ilan-gold
Copy link
Contributor

(len(Version(...).release) == 3 is always True, we must match the raw string)

Maybe I'm missing something:

>>> from packaging import version
>>> version.Version("1.0")
<Version('1.0')>
>>> version.Version("1.0").release
(1, 0)

@flying-sheep flying-sheep merged commit 6d10117 into main Sep 16, 2024
13 of 15 checks passed
@flying-sheep flying-sheep deleted the fix-towncrier-cli-style branch September 16, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants