Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add uns #126

Merged
merged 14 commits into from
Dec 2, 2023
Merged

add uns #126

merged 14 commits into from
Dec 2, 2023

Conversation

rcannood
Copy link
Collaborator

@rcannood rcannood commented Sep 19, 2023

  • Add .uns slot to AnnData classes.
  • Add roundtrip tests for .uns. Parts of the tests that are not working are disabled and marked with a # TODO:. These should be re-enabled in future PRs.
  • Improvements to how logicals, factors and/or scalars get read and written.

rcannood and others added 4 commits September 19, 2023 15:24
* origin/main:
  remove helper function that's only used once (#130)
  add authors (#113)
  suppress warnings in vignette (#127)
@rcannood
Copy link
Collaborator Author

@lazappi Shall we merge this PR so other conversion functions (Seurat & SCE) can already start using the uns?

@lazappi
Copy link
Collaborator

lazappi commented Nov 29, 2023

I'm still working through the things that are failing. Some of them are actually due to the Seurat conversion so I was going to suggest that should be merged first. Maybe that's not so easy though.

lazappi and others added 3 commits November 29, 2023 17:34
@rcannood
Copy link
Collaborator Author

I'm still working through the things that are failing. Some of them are actually due to the Seurat conversion so I was going to suggest that should be merged first. Maybe that's not so easy though.

Fair enough!

I merged a PR that skips the Seurat-related unit tests. Maybe the remaining issues are easier to fix, now ☺️

@rcannood
Copy link
Collaborator Author

rcannood commented Dec 2, 2023

I merged the main branch into this one, which splits up the different roundtrip tests based on data type. This allowed me to disable the data types which result in errors. If these tests passes, I'll merge the PR. Then, I'll create separate PRs which re-enable the failing tests per data type that is broken.

@rcannood rcannood merged commit 949aa06 into main Dec 2, 2023
7 checks passed
@rcannood rcannood deleted the add_uns branch December 2, 2023 10:02
@lazappi
Copy link
Collaborator

lazappi commented Dec 4, 2023

Ah, ok. So which branch should I work on? There were some fixes on this branch which I don't think have been merged (and others I haven't finished yet).

@rcannood
Copy link
Collaborator Author

rcannood commented Dec 4, 2023

Oh -- I apologize for merging this branch too quickly and any inconveniences I have caused!

In preparation for tomorrow's meeting, I created a bunch of PRs where each of the problems I encountered due to the extended tests (PR #137).

Perhaps the fixes implemented already fixes some of these issues 🤞

Feel free to push your changes to a new branch, or whichever branch you think is most suitable for your efforts. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants