Improve cmd/schemagen #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sylwiaszunejko can you please review this one? |
sylwiaszunejko
requested changes
Dec 27, 2023
iwittkau
commented
Jan 4, 2024
|
@sylwiaszunejko I added fixup commits, let me know when I can rebase the branch. |
It looks good now, squash the clean up commits into the previous ones to make the history of changes cleaner and for me it LGTM |
sylwiaszunejko
approved these changes
Jan 8, 2024
|
@zimnx (or @avelanarius ) - can either of you review this? |
|
Hey @zimnx can you take a look, please? 🙏🏻 |
|
I'll review it |
zimnx
reviewed
Jan 23, 2024
|
Please squash your commits into set of independent changes. Cleanup commit affecting files changed in other PR commit should be squashed. |
Co-authored by Alexander Setzer <[email protected]>
Co-authored by Alexander Setzer <[email protected]>
zimnx
approved these changes
Feb 26, 2024
|
Who can press the button to merge this? |
That would be @avelanarius |
|
@avelanarius can you merge this, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to ignore certain tables (e.g.
gocqlx_migrate), views and indexes when usingcmd/schemagen.To do this, we have implemented two new flags:
ignore, a comma-separated list of table, view or index names to ignore, this also automatically removes any unused typesignore-indexes, a bool flag that controls whether types for indexes should be generatedWe have verified the implementation by extending the existing tests.