Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop capabilities for models and IRs #491

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AxillV
Copy link

@AxillV AxillV commented Aug 7, 2024

As suggested in #445.

Currently the NAMDragDropControl class does not allow passthrough of clicks, therefore only one of: allowing drag and drop or using the plugin as normal is possible. I could add the onDrop on the individual NAMFileBrowserControl instances, but it wouldn't be as easy to use, in my opinion.

What's missing:

  • Find a way to allow NAMDragDropControl to passthrough mousevents to controls below, or place it below and allow others to pass through onDrop.
  • Add checks for valid file types, add support for IRs (couple lines of code).
  • Check if file browser works as intended after dropping in a model.
  • Add overlay to indicate to user that the plugin supports drag and drop, when holding a file over the plugin.

The first point is the one I'm mostly stuck in, everything else should be easy to implement. Any ideas?

@AxillV
Copy link
Author

AxillV commented Aug 7, 2024

UPDATE: Currently not possible to implement, see here.
Would we like to implement it only on the browsers, or wait for an implementation from IPlug's side? Don't know if I should mention a contributor so I'll leave this here for a bit.

@synchu
Copy link
Contributor

synchu commented Jan 6, 2025

I suggested an implementation, as mentioned in #445 (link to the fork is there) and figured that I will add today a compiled (Windows) VST3 and standalone binaries to aid potential testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants