Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine static_code_analysis.yml with release_notes.yml #426

Merged
merged 6 commits into from
Jan 10, 2025

Conversation

R-Palazzo
Copy link
Contributor

CU-86b2xqvmu
Resolve #421

@R-Palazzo R-Palazzo self-assigned this Jan 8, 2025
@sdv-team
Copy link
Contributor

sdv-team commented Jan 8, 2025

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.25%. Comparing base (b660824) to head (27e4398).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #426   +/-   ##
=======================================
  Coverage   85.25%   85.25%           
=======================================
  Files          10       10           
  Lines         780      780           
=======================================
  Hits          665      665           
  Misses        115      115           
Flag Coverage Δ
integration 85.12% <ø> (ø)
unit 47.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +42 to +44
- name: Save static code analysis
run: bandit -r . -x ./tests,./scripts,./build -f txt -o static_code_analysis.txt --exit-zero

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for all of these can we manually trigger it and see what the code analysis looks like? I've had trouble before where some files weren't being filtered out properly so I just want to make sure

@R-Palazzo R-Palazzo merged commit 6ed1f19 into main Jan 10, 2025
50 of 51 checks passed
@R-Palazzo R-Palazzo deleted the issue-421-prepare-release branch January 10, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine static_code_analysis.yml with release_notes.yml
4 participants