Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OneHotEncoder support for categoricals #759

Merged
merged 7 commits into from
Feb 7, 2024
Merged

Conversation

fealho
Copy link
Member

@fealho fealho commented Feb 5, 2024

CU-86az0h0pg, Resolve #751.

@sdv-team
Copy link
Contributor

sdv-team commented Feb 5, 2024

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (deb0f74) 100.00% compared to head (1686fa2) 100.00%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #759   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         2007      2007           
=========================================
  Hits          2007      2007           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fealho fealho marked this pull request as ready for review February 5, 2024 17:54
@fealho fealho requested a review from a team as a code owner February 5, 2024 17:54
@fealho fealho requested review from R-Palazzo and pvk-developer and removed request for a team February 5, 2024 17:54
Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
In the reverse transform, should it be set back to Category? @npatki
If yes, could we check this as well?

@npatki
Copy link
Contributor

npatki commented Feb 6, 2024

Yeah we always try to reverse to the same dtype that is inputted. That would be great!

@fealho fealho requested a review from R-Palazzo February 7, 2024 14:45
Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fealho fealho merged commit 41ac439 into main Feb 7, 2024
45 checks passed
@fealho fealho deleted the issue-751-one-hote branch February 7, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OneHotEncoder doesn't support dtype 'category'
6 participants