opt: output logs #673
Merged
opt: output logs #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtable_events/dtable_io/utils.py
Outdated
| logger.addHandler(handler) | ||
|
|
||
| if ENABLE_SEATABLE_EVENTS_LOGS_TO_STDOUT: |
There was a problem hiding this comment.
改为 SEATABLE_LOG_TO_STDOUT。使用通用配置，每一个组件都读取这个。并且从env里读取
dtable_events/app/log.py
Outdated
|
|
||
| if ENABLE_SEATABLE_EVENTS_LOGS_TO_STDOUT: | ||
| # logs to stdout | ||
| stdout_formatter = logging.Formatter('[seatable_event] [%(asctime)s] %(filename)s[line:%(lineno)d] [%(levelname)s] %(message)s') |
There was a problem hiding this comment.
seatable_event 改为 dtable-events
dtable_events/app/log.py
Outdated
|
|
||
| def _basic_config(self): | ||
| # Log to stdout. Mainly for development. | ||
| kw = { | ||
| 'format': '[%(asctime)s] %(filename)s[line:%(lineno)d] [%(levelname)s] %(message)s', | ||
| 'format': '[dtable_event] [%(asctime)s] %(filename)s[line:%(lineno)d] [%(levelname)s] %(message)s', |
There was a problem hiding this comment.
dtable_event 改为 dtable-events
wacmkxiaoyi
force-pushed
the
opt_output_logs
branch
from
f343647 to
0dad414
Compare
dtable_events/app/log.py
Outdated
|
|
||
| if os.environ.get('SEATABLE_LOG_TO_STDOUT', False): | ||
| # logs to stdout | ||
| stdout_formatter = logging.Formatter('[dtable_events] [%(asctime)s] %(filename)s[line:%(lineno)d] [%(levelname)s] %(message)s') |
There was a problem hiding this comment.
dtable_events -> dtable-events
dtable_events/dtable_io/utils.py
Outdated
| @@ -34,6 +35,31 @@ | |||
| IMG_URL_PREFIX = 'file://dtable-bundle/asset/images/' | |||
| DTABLE_IO_DIR = '/tmp/dtable-io/' | |||
|
|
|||
| def setup_logger(logname): | |||
There was a problem hiding this comment.
dtable-io 导入的是 dtable-events/dtable_events/app/log.py 里的 setup_logger，需要修改这里的 setup_logger。dtable_events/dtable_io/utils.py 不用添加。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.