Fix auto rule link records #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r350178982
force-pushed
the
fix-auto-rule-link-records
branch
from
42cd720 to
e71bed3
Compare
r350178982
reviewed
Nov 23, 2024
| else: | ||
| return value | ||
| def gen_filter(self, column, other_column): | ||
| """Generate a filter dict to filter other table |
There was a problem hiding this comment.
这里总共就13中if列类型， 看了一下， 缺少 if column['type'] == ColumnTypes.EMAIL 处理
r350178982
reviewed
Nov 23, 2024
| return self.gen_filter({'key': column['key'], 'type': ColumnTypes.NUMBER}, other_column) | ||
| elif column_data.get('result_type') == 'bool': | ||
| return self.gen_filter({'key': column['key'], 'type': ColumnTypes.CHECKBOX}, other_column) | ||
|
|
There was a problem hiding this comment.
这里是不是还需要加入 result_type == 'date' 类型呢？
r350178982
reviewed
Nov 23, 2024
dtable_events/automations/actions.py
Outdated
| 'filter_predicate': self.COLUMN_FILTER_PREDICATE_MAPPING[ColumnTypes.CHECKBOX] | ||
| } | ||
| elif other_column['type'] == ColumnTypes.FORMULA: | ||
| if other_column_data.get('result') == 'bool': |
There was a problem hiding this comment.
other_column_data.get('result') --> other_column_data.get('result_type')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.