Add message schema validators #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryzing
force-pushed
the
eduard/schema-validators
branch
from
c89bad6 to
712848f
Compare
aryzing
force-pushed
the
eduard/schema-validators
branch
from
712848f to
ca12279
Compare
teebszet
reviewed
Jun 20, 2024
teebszet
approved these changes
Jun 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates sats-connect-core to derive types from (runtime) schema validators. The validators are exported, and can be used at type assertion boundaries, such as when data is passed by a third party app to the background script, or when the background script passes data via url params to the extension popup.
Given JSON RPC 2.0 is an integral part of sats-connect, schema validators for RPC calls are also inlcuded.
The validator lib is marked as a peer dependency to better integrate with third party use of sats-connect. The schema validators are pure functions, and any modern build tool should tree-shake them away if not used.
This PR updates the types of 3 methods (getInfo, getAddresses, getAccounts), with remaining methods planned to be incrementally updated with future PRs.
A couple of new methods for connecting and disconnecting the wallet are also added.