feat: Update tag display system #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sort tags alphabetically * Remove "Selected Articles" * When a tag is displayed, only show articles matching the tag * Fixed CSS on tags-dropdown
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* Functionality remains, as far as I can tell, the same. I mostly just removed a few duplicate methods related to tagsList and added documentation to make the code easier for new readers.
Also fixed layering issue due to background transparency
The code for OR selection was just commented out since I'm not sure if others actually wanted this, or if it was just me. Can be reverted if so desired.
Better to have all styles in the .css file
|
I like this. I think it's clear, unrepetitive, and the initial idea of how I portrayed it :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frameworks PR Checklist
Thank you for contributing to the Security Frameworks! Before you open a PR, make sure to read information for contributors and take a look at the following checklist:
Summary
Updated the tag display system to clean up the UX and provide more consistancy.
@tebayoso - this is your code & I would imagine your decision to architect the tag system.