Tell system to reinitialize when it refuses to give us data we need #845
+67
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft, only because based on #835. One way to test this is to do a backup, then manually remove all existing snapshots from the backend. Then restart the Seedvault process and do another backup and watch the log for |
grote
force-pushed
the
no-data-no-snapshot
branch
from
f2665fa to
eaee625
Compare
Another hacky workaround to fix a hacky workaround. We had talked to Google about the backup API not getting notified when essential K/V apps like @pm@ don't have new data for backup. The only option they offered is BackupMonitor which gets the information at least, but out of process on another thread. So we implemented a hacky workaround where BackupMonitor tells SnapshotCreator to extract backup data from an old snapshot. Unfortunately, it is possible that we do a backup run which includes @pm@, but encounters an error later, so the system cancels the entire backup which causes us not to have @pm@ data in a snapshots for re-use. Still, the system thinks we backed up @pm@ and doesn't give us its data.
grote
force-pushed
the
no-data-no-snapshot
branch
from
eaee625 to
f4b32e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another hacky workaround to fix a hacky workaround.
We had talked to Google about the backup API not getting notified when essential K/V apps like
@pm@don't have new data for backup. The only option they offered isBackupMonitorwhich gets the information at least, but out of process on another thread.So we implemented a hacky workaround where
BackupMonitortellsSnapshotCreatorto extract backup data from an old snapshot.Unfortunately, it is possible that we do a backup run which includes
@pm@, but encounters an error later, so the system cancels the entire backup which causes us not to have@pm@data in a snapshots for re-use. Still, the system thinks we backed up@pm@and doesn't give us its data.Closes #818