Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize mentee public endpoint and sanitize mentor details #150

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

Madhawa97
Copy link
Member

Purpose

The purpose of this PR is to fix #149

Goals

Hide unwanted fields from the returned data

Approach

  • Create a public get mentee endpoint

  • Protect existing endpoints

  • Implement proper util methods

  • Also adds fix for getMenteesSchema

Screenshots

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

@Madhawa97 Madhawa97 requested a review from anjula-sack August 13, 2024 06:32
Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @Madhawa97

@anjula-sack anjula-sack merged commit bf901eb into sef-global:main Aug 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix data sanitisation of mentor and mentee endpoints
2 participants