-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/issue 136 paginated routes #159
Merged
anjula-sack
merged 16 commits into
sef-global:main
from
dsmabulage:bugfix/issue-136_paginated-routes
Aug 26, 2024
Merged
Bugfix/issue 136 paginated routes #159
anjula-sack
merged 16 commits into
sef-global:main
from
dsmabulage:bugfix/issue-136_paginated-routes
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lage:dsmabulage/scholarx-backend into bugfix/issue-136_paginated-routes
anjula-sack
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! @dsmabulage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #136
Goals
The goal is to implement pagination for necessary GET routes to improve performance and usability.
Approach
Pagination will be added to the required GET routes by modifying the existing query handling mechanisms. This will involve updating the controller methods to accept pagination parameters and adjust the database queries accordingly. Additionally, the response structure will be modified to include pagination metadata such as total pages, current page, and items per page.
Screenshots
Checklist
Related PRs
Test environment
Learning