Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/issue 136 paginated routes #159

Merged

Conversation

dsmabulage
Copy link
Contributor

Purpose

The purpose of this PR is to fix #136

Goals

The goal is to implement pagination for necessary GET routes to improve performance and usability.

Approach

Pagination will be added to the required GET routes by modifying the existing query handling mechanisms. This will involve updating the controller methods to accept pagination parameters and adjust the database queries accordingly. Additionally, the response structure will be modified to include pagination metadata such as total pages, current page, and items per page.

Screenshots

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @dsmabulage

@anjula-sack anjula-sack merged commit 3130cf7 into sef-global:main Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pagination for GET routes
2 participants