-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Partial Updates to User Profile in updateProfile Function #166
Merged
anjula-sack
merged 11 commits into
sef-global:main
from
mayura-andrew:monthly-checking-feature
Sep 10, 2024
Merged
Handle Partial Updates to User Profile in updateProfile Function #166
anjula-sack
merged 11 commits into
sef-global:main
from
mayura-andrew:monthly-checking-feature
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of directly passing individual fields to the updateProfile function, refactor the logic to use a single updateData object. This object contains the updated fields for the profile, such as primary_email, first_name, last_name, and image_url. This change improves code readability and maintainability. Related to sef-global#165
anjula-sack
requested changes
Sep 9, 2024
src/services/profile.service.ts
Outdated
Comment on lines
18
to
26
|
||
const updatedFields: Partial<Profile> = {} | ||
|
||
if (updateData.primary_email) | ||
updatedFields.primary_email = updateData.primary_email | ||
if (updateData.first_name) updatedFields.first_name = updateData.first_name | ||
if (updateData.last_name) updatedFields.last_name = updateData.last_name | ||
if (updateData.image_url) updatedFields.image_url = updateData.image_url | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
const updatedFields: Partial<Profile> = {} | |
if (updateData.primary_email) | |
updatedFields.primary_email = updateData.primary_email | |
if (updateData.first_name) updatedFields.first_name = updateData.first_name | |
if (updateData.last_name) updatedFields.last_name = updateData.last_name | |
if (updateData.image_url) updatedFields.image_url = updateData.image_url | |
const { primary_email, first_name, last_name, image_url } = updateData; | |
const updatedFields: Partial<Profile> = { primary_email, first_name, last_name, image_url }; |
anjula-sack
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #165
Goals
Handle errors gracefully and return appropriate error messages.
Approach
Screenshots
Checklist
Related PRs
Test environment
Nodejs : V20.15
OS: Linux Mint 21.3
Learning