Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination support for frontend #182

Merged
merged 10 commits into from
Sep 9, 2024

Conversation

Madhawa97
Copy link
Member

@Madhawa97 Madhawa97 commented Sep 6, 2024

Purpose

The purpose of this PR is to fix #181

Goals

The pagination support for the backend was recently added and this PR updates the relevant endpoints in the frontend to support the feature.

Approach

Screenshots

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

@Madhawa97 Madhawa97 marked this pull request as ready for review September 7, 2024 19:23
src/pages/Mentors/index.tsx Outdated Show resolved Hide resolved
@Madhawa97
Copy link
Member Author

Madhawa97 commented Sep 9, 2024

Updated to match with backend pagination removal for categories

We may need a new approach to get the Total Mentee Slots: X count in the admin mentor applications page.
Also the totalItemCount sends when filtered by category seems wrong and should be fixed in the backend.
@anjula-sack

@Madhawa97 Madhawa97 changed the title Add pagination support for the public mentors page Add pagination support for frontend Sep 9, 2024
@anjula-sack
Copy link
Member

Updated to match with backend pagination removal for categories

We may need a new approach to get the Total Mentee Slots: X count in the admin mentor applications page. Also the totalItemCount sends when filtered by category seems wrong and should be fixed in the backend. @anjula-sack

Can you create an issue for this?

@anjula-sack anjula-sack merged commit 6afa7c6 into sef-global:main Sep 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pagination support for the frontend
2 participants