-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mentor profile UI #183
Conversation
@AnsarMahir The tests are failing can you check? |
@anjula-sack The issue seems like package-lock and package-json was not in sync. did the necessary changes |
can you update this to version 18 in e2e.yml? @AnsarMahir |
changed the node version to 18 from 16. @anjula-sack |
Still failing @AnsarMahir. Can you remove the package-lock.json changes? |
@Madhawa97 Can you help @AnsarMahir with this actions failure? |
@anjula-sack updated the package.json and package-lock file by replacing them with the files in the repo. |
Co-authored-by: Anjula Shanaka <[email protected]>
@anjula-sack Do not merge |
@anjula-sack did the changes |
<InformationModal | ||
isOpen={isOpen} | ||
headline="Withdraw your current application" | ||
body={`Are you sure you want to withdraw your current application and apply for ${ | ||
mentor?.application.firstName ?? '' | ||
} ${mentor?.application.lastName ?? ''}?`} | ||
onConfirm={revokeApplication} | ||
onClose={closeModal} | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is removed? @AnsarMahir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anjula-sack had to go back to an old commit due to removing the mentors profession. Copied that code and this was from a latest one so it also gone. Let me fix it this by today
@anjula-sack Hopefully done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! @AnsarMahir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lint failure
@anjula-sack fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! @AnsarMahir
Purpose
The purpose of this PR is to Update mentor profile UI #171
Goals
Approach
Screenshots
Checklist
Related PRs
Test environment
Learning
closes #171