Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mentor profile UI #183

Merged
merged 19 commits into from
Sep 15, 2024
Merged

Update mentor profile UI #183

merged 19 commits into from
Sep 15, 2024

Conversation

AnsarMahir
Copy link
Contributor

@AnsarMahir AnsarMahir commented Sep 8, 2024

Purpose

The purpose of this PR is to Update mentor profile UI #171

Goals

Approach

Screenshots

image

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

closes #171

@anjula-sack
Copy link
Member

@AnsarMahir The tests are failing can you check?

@AnsarMahir
Copy link
Contributor Author

@anjula-sack The issue seems like package-lock and package-json was not in sync. did the necessary changes

@anjula-sack
Copy link
Member

can you update this to version 18 in e2e.yml? @AnsarMahir

@AnsarMahir
Copy link
Contributor Author

changed the node version to 18 from 16. @anjula-sack

@anjula-sack
Copy link
Member

Still failing @AnsarMahir. Can you remove the package-lock.json changes?

@anjula-sack
Copy link
Member

@Madhawa97 Can you help @AnsarMahir with this actions failure?

@AnsarMahir
Copy link
Contributor Author

@anjula-sack updated the package.json and package-lock file by replacing them with the files in the repo.

package.json Outdated Show resolved Hide resolved
@AnsarMahir
Copy link
Contributor Author

AnsarMahir commented Sep 14, 2024

@anjula-sack Do not merge

@AnsarMahir
Copy link
Contributor Author

@anjula-sack did the changes

Comment on lines 232 to 240
<InformationModal
isOpen={isOpen}
headline="Withdraw your current application"
body={`Are you sure you want to withdraw your current application and apply for ${
mentor?.application.firstName ?? ''
} ${mentor?.application.lastName ?? ''}?`}
onConfirm={revokeApplication}
onClose={closeModal}
/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is removed? @AnsarMahir

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjula-sack had to go back to an old commit due to removing the mentors profession. Copied that code and this was from a latest one so it also gone. Let me fix it this by today

@AnsarMahir
Copy link
Contributor Author

@anjula-sack Hopefully done.

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! @AnsarMahir

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lint failure

@AnsarMahir
Copy link
Contributor Author

There's a lint failure

@anjula-sack fixed

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! @AnsarMahir

@anjula-sack anjula-sack merged commit 9f1081d into sef-global:main Sep 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update mentor profile UI
2 participants