Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Breadcrumb names into one line on mobile view #186

Merged
merged 5 commits into from
Sep 15, 2024

Conversation

Sanjana0823
Copy link
Contributor

Purpose

The purpose of this PR is to fix #177

Goals

  • The breadcrumb should display all names on a single line

Approach

  • Change text-sm to text-xs sm:text-sm md:text-base that the text size will be xs (extra small) on mobile screens, change to sm (small) on small screens (640px and above), and increase to base (normal size) on medium screens (768px and above).

Screenshots

image

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

Comment on lines 17 to 32
<div className="flex items-center">
<button className="transform rotate-180 md:hidden">
<Link
to={`/mentors/${mentee?.mentor.uuid ?? ''}`}
className="block transition hover:text-gray-700 md:hidden ml-2"
>
<ChevronRightIcon />
</Link>
</button>
<Link
to={`/mentors/${mentee?.mentor.uuid ?? ''}`}
className="block transition hover:text-gray-700 md:hidden ml-2"
>
Back
</Link>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div className="flex items-center">
<button className="transform rotate-180 md:hidden">
<Link
to={`/mentors/${mentee?.mentor.uuid ?? ''}`}
className="block transition hover:text-gray-700 md:hidden ml-2"
>
<ChevronRightIcon />
</Link>
</button>
<Link
to={`/mentors/${mentee?.mentor.uuid ?? ''}`}
className="block transition hover:text-gray-700 md:hidden ml-2"
>
Back
</Link>
</div>
<div className="flex items-center">
<Link
to={`/mentors/${mentee?.mentor.uuid ?? ''}`}
className="flex items-center transition hover:text-gray-700 md:hidden"
>
<span className="transform rotate-180"><ChevronRightIcon /></span>
<span className="ml-2">Back</span>
</Link>
</div>

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! @Sanjana0823

@anjula-sack anjula-sack merged commit fd1cbda into sef-global:main Sep 15, 2024
3 checks passed
@Sanjana0823
Copy link
Contributor Author

Good job! @Sanjana0823

Thank you @anjula-sack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breadcrumb names split into two lines on mobile view
2 participants