Implement user authentication #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhawa97
force-pushed
the
add-logic-func
branch
from
42d8b12 to
25523a2
Compare
anjula-sack
requested changes
Oct 21, 2023
src/App.tsx
Outdated
| const App: React.FC = () => { | ||
| const { user, setUser } = useContext(UserContext); | ||
|
|
||
| user !== null && console.log('user is authenticated'); |
There was a problem hiding this comment.
the useEffect was defined in the UserProvider to invoke the getUser() each time the UserProvider mounts.
But as requested I changed it to invoke the getUser() each time the App mounts.
and the getUser() has also been sent to the App via Context. Could you let me know which way is correct/preferred?
Madhawa97
force-pushed
the
add-logic-func
branch
from
6573c4e to
d2de477
Compare
anjula-sack
requested changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #55
Goals
Implement a robust and user-friendly login mechanism that allows users to securely log in using their email and password credentials.
Approach
Implement a login mechanism that allows users to log in using their credentials (email and password) while utilizing HTTP-only Cookies for enhanced security.
Upon successful authentication, save the authenticated user's data in context. This context should be accessible from any part of the application, ensuring that user-specific information is available where needed.
Screenshots
Checklist
Related PRs
Test environment
Node v18, macOS latest, chrome latest
Learning
User Authentication, Typescript, useContext