Taproot Miniscript

[odudex]

What is this PR for?

After having P2WSH Miniscript compatibility added to develop branch this PR adds compatibility for Taproot Miniscripts, first tests done targeting Liana as coordinator.

What is the purpose of this pull request?

• Bug fix
• New feature
• Docs update
• Other

[codecov]

Codecov Report

Attention: Patch coverage is 66.25000% with 108 lines in your changes missing coverage. Please review.

Project coverage is 93.43%. Comparing base (824e8ee) to head (298bd53).

Files with missing lines	Patch %	Lines
src/krux/pages/wallet_settings.py	46.42%	45 Missing ⚠️
src/krux/pages/home_pages/wallet_descriptor.py	55.88%	30 Missing ⚠️
src/krux/psbt.py	77.89%	21 Missing ⚠️
src/krux/pages/login.py	64.70%	6 Missing ⚠️
src/krux/wallet.py	85.00%	6 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #498      +/-   ##
===========================================
- Coverage    94.37%   93.43%   -0.95%     
===========================================
  Files           74       74              
  Lines         8104     8297     +193     
===========================================
+ Hits          7648     7752     +104     
- Misses         456      545      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[odudex]

At this point I'm prioritizing SD card signing for miniscript, as Liana does not support QR codes.
I'm rethinking SD card flow, also having multisig in mind. On current commit I won't trim any data of PSBT, this way, in a multi-device setup you can:
Create PSBT on PC -> Sign in device 1 -> Sign in device 2 -> Broadcast on PC.
(Without needing to load device 1 signatures on PC prior to sign with device 2)

[jdlcdl]

Recording thoughts after testing this at commit d467330:

Without loading a mnemonic, using tools / descriptor addresses, to load a wallet descriptor from liana

• WORKS: to load and find correct addresses for miniscript-wsh as well as miniscript-tr
• TODO: however it shows "TR Miniscript" in both cases, instead of showing WSH when that's the case. (fixed in e4d6530)
  ... if doing the same when a mnemonic is loaded:
• still works to find correct addresses just like above, still needs a correction on the title to reflect WSH when applicable (also fixed),
• TODO: perhaps a mismatch check needs to be added, so that when krux is expecting miniscript WSH and instead loads a TR descriptor, a warning is displayed. (also fixed) Also, primary and heir keys may have different paths, so relaxing how strict that check is needs fine-tuning. (fixed: informs and is tolerant)

When signing a PSBT from liana w/ wallet descriptor:

• WORKS: to raise a policy-mismatch if wrong wallet descriptor is loaded,
  and without a wallet descriptor loaded:
• WORKS: to show policy "p2tr" and list of key-origin fingerprints, for a psbt that is miniscript-p2tr,
• WORKS: to show policy "p2wsh" w/o list of keys but could be improved to include key-origin fingerprints (also improved) -- for a psbt that is miniscript-wsh,
  and overall:
• WORKS: to display what is being spent, whether it's change/self-transfer and what the fees are
• appears to create valid signatures, however I had to finalizepsbt and sendrawtransaction on a signet node because liana didn't show me the "broadcast" button.... but odudex has explained how to get around this for next time (save first, then sign, then update, then can broadcast)

Learned from odudex that we cannot count on specific derivation paths, different wallets (nunchuk's m/87'/0'/0' tap multisig) may use their own preferred paths and krux may need to support custom derivation path to create / recover for different wallet softwares. (resolved in bbb1d4d)

Also noted that liana conveniently uses the bech32 checksum, which is the suffix on the wallet descriptor, as a wallet identifier, and this is very nice... perhaps something for krux to adopt, to display when loading a descriptor.

Also todo: review/tests for embit changes, tests for krux too.

[jdlcdl]

refactor? If we get here, we might as well just return addr.lower() and avoid re-setting this var, and more isinstance() checks?

And if that refactor happens, can avoid the isinstance() check at 463 and bring the one at 469 into the try: leg, as it was originally