Merge pull request #734 from semaphore-protocol/fix/convert-hex-pk

Convert hexadecimal private key before signing messages
semaphore-protocol · Mar 28, 2024 · d9d97de · d9d97de
2 parents c795ddc + 88df87e
commit d9d97de
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/packages/identity/src/index.ts b/packages/identity/src/index.ts
@@ -112,7 +112,11 @@ export class Identity {
      * @returns A {@link https://zkkit.pse.dev/types/_zk_kit_eddsa_poseidon.Signature.html | Signature} object containing the signature components.
      */
     public signMessage(message: BigNumberish): Signature<bigint> {
-        return signMessage(this.privateKey, message)
+        const privateKey = isHexadecimal(this.privateKey, false)
+            ? hexadecimalToBuffer(this.privateKey)
+            : this.privateKey
+
+        return signMessage(privateKey, message)
     }
 
     /**

diff --git a/packages/identity/tests/index.test.ts b/packages/identity/tests/index.test.ts
@@ -54,12 +54,20 @@ describe("Identity", () => {
     })
 
     describe("# verifySignature", () => {
-        it("Should verify a signature", () => {
+        it("Should verify a signature with a text private key", () => {
             const identity = new Identity(privateKeyText)
 
             const signature = identity.signMessage("message")
 
             expect(Identity.verifySignature("message", signature, identity.publicKey)).toBeTruthy()
         })
+
+        it("Should verify a signature with hexadecimal private key", () => {
+            const identity = new Identity(privateKeyHexadecimal)
+
+            const signature = identity.signMessage("message")
+
+            expect(Identity.verifySignature("message", signature, identity.publicKey)).toBeTruthy()
+        })
     })
 })