fix: frozen string literal issue for ruby 3.4.0 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prepare for ruby 3.4.0 and making strings frozen by default, we add `+` operator to make the string mutable
chaadow
changed the title
tmimura39
reviewed
Dec 17, 2024
| url = [add_version(''), *@url_path].join('/') | ||
| url = build_query_params(url, query_params) if query_params | ||
| url = [add_version(+''), *@url_path].join('/') | ||
| url = build_query_params(+url, query_params) if query_params |
There was a problem hiding this comment.
I don't think this url is frozen because it is not “string literal” 🤔
Suggested change
| url = build_query_params(+url, query_params) if query_params | |
| url = build_query_params(url, query_params) if query_params |
There was a problem hiding this comment.
It is. The line before does a join('/')
So it creates a string literal
There was a problem hiding this comment.
@childish-sambino, @rakatyal, @garethpaul, @tmimura39. Sorry to bother you but could look at this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #136
To prepare for ruby 3.4.0 and making strings frozen by default, I've stumbled upon these string mutations in my specs while trying to send an email
future of frozen string literals in ruby : https://gist.github.com/fxn/bf4eed2505c76f4fca03ab48c43adc72
similar to fog/fog-aws#709
Checklist
If you have questions, please file a support ticket.