feat: Add data residency for eu and global regions #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrutiburman
changed the title
|
@gladysmae08 @tbischel Please review the unit tests to validate the expected behaviour when both setters |
shrutiburman
merged commit 36a576c
into
sendgrid:DII1228-add-data-residency
1 check passed
gladysmae08
reviewed
Nov 1, 2023
| public void testSetResidency_happy_path_global() { | ||
| SendGrid sg = new SendGrid(SENDGRID_API_KEY); | ||
| sg.setDataResidency("global"); | ||
| Assert.assertEquals(sg.getHost(), "api.eu.sendgrid.com"); |
There was a problem hiding this comment.
shouldn't this be api.sendgrid.com?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
A short description of what this PR does.
Checklist
If you have questions, please file a support ticket.