-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement Lazy Loading for Header Parsing to Avoid Unnecessary Validation #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkucaj
force-pushed
the
feature/lazy-parsing
branch
4 times, most recently
from
December 24, 2024 09:03
a577b00
to
67a9964
Compare
klkucaj
force-pushed
the
feature/lazy-parsing
branch
2 times, most recently
from
January 9, 2025 10:57
9c90c34
to
838824c
Compare
SandPod
force-pushed
the
main
branch
7 times, most recently
from
January 9, 2025 12:28
db7e237
to
e2607bc
Compare
klkucaj
force-pushed
the
feature/lazy-parsing
branch
from
January 9, 2025 12:33
838824c
to
9dfea59
Compare
klkucaj
force-pushed
the
feature/lazy-parsing
branch
from
January 9, 2025 12:46
9dfea59
to
fdd40a7
Compare
SandPod
requested changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat change, the Lazy Init looks like a minimal and solid solution
I'm missing a general test that is not connected to a specific header. This can be used to validate that we handle the "exception" correctly even if we have no headers that throw in strict mode.
SandPod
requested changes
Jan 9, 2025
SandPod
requested changes
Jan 10, 2025
…rved during JSON map conversion
SandPod
reviewed
Jan 10, 2025
…ncluded even when a header was not set and it is null
SandPod
reviewed
Jan 10, 2025
SandPod
reviewed
Jan 10, 2025
SandPod
reviewed
Jan 10, 2025
SandPod
reviewed
Jan 10, 2025
SandPod
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR implements lazy loading for header parsing and validation. Headers are now parsed and validated only when explicitly accessed by the request handler, improving performance and avoiding unnecessary validation for unused headers.
Closes #10