Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use new auth object in session. #181

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Conversation

gazialankus
Copy link
Contributor

Similar fix to issue #115

Copy link
Contributor

@hampuslavin hampuslavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👏

@hampuslavin hampuslavin changed the title session.auth.authenticatedUserId is not there anymore. fix: Use new auth object in session Oct 16, 2024
@hampuslavin hampuslavin changed the title fix: Use new auth object in session fix: Use new auth object in session. Oct 16, 2024
Copy link
Contributor

@hampuslavin hampuslavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gazialankus Actually, would you mind just updating the paragraph above this change to reflect your change? ☺️

@gazialankus
Copy link
Contributor Author

Ah I completely missed that, thank you! I was about to call it a property but Dart docs calls it a getter, I hope this is the right way to call it.

Copy link
Contributor

@SandPod SandPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Thanks for the contribution! 🙏

@SandPod SandPod requested a review from hampuslavin January 20, 2025 16:25
@SandPod SandPod dismissed hampuslavin’s stale review January 20, 2025 16:26

I have taken over the review

@SandPod SandPod merged commit bef4eab into serverpod:main Jan 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants