Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature = "cargo-clippy" deprecation #516

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix feature = "cargo-clippy" deprecation #516

merged 1 commit into from
Mar 4, 2024

Conversation

rex4539
Copy link
Contributor

@rex4539 rex4539 commented Feb 28, 2024

Copy link
Contributor

@nical nical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Reading the blog post it looks like the clippy cfg will arrive in rustc 1.78 which would mean the annotations would be ignored until then.

I think that we can instead replace all of the annotations with the simpler #[allow(clippy::just_underscores_and_digits)] form which should work with euclid's msrv (1.56).

@rex4539
Copy link
Contributor Author

rex4539 commented Mar 4, 2024

Sounds good.

@rex4539 rex4539 requested a review from nical March 4, 2024 11:15
@nical nical enabled auto-merge March 4, 2024 14:05
@nical
Copy link
Contributor

nical commented Mar 4, 2024

Thanks!

@nical nical added this pull request to the merge queue Mar 4, 2024
Merged via the queue into servo:master with commit 426c59a Mar 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants