Add table_oid and column_id to column structure of prepared statements #1084
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to access the underlying table and column of a query and found those two information not exposed in the
statement::Column
structure.I also simplified the
Debug
implementation ofColumn
by usingr#type
rather thantype_
so#[derive(Debug)]
can be used. As the argument list grew longer I also removed thenew
method in favor of making all the fieldspub(crate)
.Should we maybe expose the three remaining fields as well?
type_size: i16
type_modifier: i32
format: i16
I don't have an immediate need for them. They could provide useful in the future, though.
What are your thoughts on using
NonZeroU32
andNonZeroI16
? I'm not 100% sure if that's really a good choice for the type. Yet it felt somewhat natural to use it as0
denotes that this information is not available.